Custom sounds in actions & Fix for <1.21.3 #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hich throws errors on versions below 1.21.3
|
I personally would prefer if we added adventure sound support instead. I'm going to look into a better way to serialize actions since a single string can make things complicated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for custom sounds in [sound], [broadcastsound] & [broadcastsoundworld]
Works as an alternative to #158 and closes #157 since we use a string representing the sound's namespace instead of a Sound.
This also means that if a sound's namespace is different from the Sound's name in Spigot's Sound Enum (now Interface), it won't work, though from what I've seen, aside from . being replaced by _ (which I took in account) and namespaces being fully lowercased, they all seem to be exactly the same so there shouldn't be any issues.